Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated endpoints containing _xpack. #48170

Merged
merged 5 commits into from
Oct 29, 2019

Conversation

jtibshirani
Copy link
Contributor

@jtibshirani jtibshirani commented Oct 17, 2019

The endpoints with _xpack in their path were deprecated in 7.x and can now be
removed. This commit removes deprecated endpoints for the following APIs:

  • deprecation
  • graph
  • license
  • monitoring
  • rollup
  • SQL
  • watcher

Relates to #35958.

@jtibshirani jtibshirani changed the title Remove deprecated graph explore endpoints. Remove deprecated endpoints containing _xpack. Oct 17, 2019
@jtibshirani jtibshirani added :Core/Infra/REST API REST infrastructure and utilities and removed :Analytics/Graph labels Oct 17, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (:Core/Infra/REST API)

The endpoints with _xpack in their path were deprecated in 7.x and can now be
removed. This commit removes deprecated endpoints for the following APIs:
* deprecation
* graph
* license
* monitoring
* rollup
* SQL
* watcher
@jtibshirani
Copy link
Contributor Author

@elasticmachine run elasticsearch-ci/packaging-sample-matrix

Copy link
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

In 7.0, we deprecated REST endpoints that contain `_xpack` in their path. These
endpoints are now removed in 8.0. Each endpoint that was deprecated and removed
is replaced with a new endpoint that does not contain `_xpack`. As an example,
`/{index}/_xpack/graph/_explore` is replaced by `/{index}/graph/_explore`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't graph prefixed with an underscore, ie _graph?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, thanks. Yes _xpack has been removed but also graph/_explore -> _graph/explore.

@jtibshirani
Copy link
Contributor Author

@elasticmachine run elasticsearch-ci/bwc

@jtibshirani jtibshirani merged commit a12b409 into elastic:master Oct 29, 2019
@jtibshirani jtibshirani deleted the graph-endpoints branch October 29, 2019 01:23
edsavage added a commit to edsavage/elasticsearch that referenced this pull request Jul 20, 2020
Extends the work done in elastic#48170 to the ml module
edsavage added a commit that referenced this pull request Jul 20, 2020
Extends the work done in #48170 to the ml module
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>breaking :Core/Infra/REST API REST infrastructure and utilities v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants